Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activating multiple keys #3747

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

Fix activating multiple keys #3747

wants to merge 1 commit into from
+33 −42

Conversation

samaradel
Copy link
Contributor

Description

  • Activate Active column
  • Support multiple keys
  • Remove selected class from unselected keys

Changes

image

Screencast.from.01-12-24.19.16.27.webm

Related Issues

Tested Scenarios

  • Create multiple SSH keys
  • Activate/deactivate any of them
  • Select / multi-select keys before deploying any solution

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 will be requested when the pull request is marked ready for review AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary will be requested when the pull request is marked ready for review zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama will be requested when the pull request is marked ready for review maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary will be requested when the pull request is marked ready for review MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad will be requested when the pull request is marked ready for review Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid will be requested when the pull request is marked ready for review amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar will be requested when the pull request is marked ready for review AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R will be requested when the pull request is marked ready for review 0oM4R is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samaradel